Re: Adding REPACK [concurrently]
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Antonin Houska <ah@cybertec.at>, Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
Matthias van de Meent <boekewurm+postgres@gmail.com>, Pg Hackers <pgsql-hackers@lists.postgresql.org>,
Robert Treat <rob@xzilla.net>
Date: 2026-05-26T15:31:33Z
Lists: pgsql-hackers
On 2026-May-25, Zhijie Hou (Fujitsu) wrote: > After listening to the REPACK talk at pgconf.dev this year, I understand that > WAL accumulation during REPACK CONCURRENTLY is not intended behavior. I think we > can consider fixing this in the current release. Attached is the rebased > patch, with comments adjusted based on Chao Li's comments. You're right, this is a thinko. I'll look at your patch hoping to get it pushed shortly. I wonder if we should add a TAP test to verify that WAL files are actually removed? Sounds a bit excessive TBH, but maybe it isn't really. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "I think my standards have lowered enough that now I think 'good design' is when the page doesn't irritate the living f*ck out of me." (JWZ)