Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API

Hi Nikita,

On 2026-Jun-02, Никита Калинин wrote:

> > On 2 Jun 2026, at 00:12, Álvaro Herrera <alvherre@kurilemu.de> wrote:

> But does the error message need to be that detailed? Perhaps something like
> 
> "ERROR: wrong magic number in "pgrepack" decoder plugin"
> would be sufficient.

Maybe.  Getting 0x00000000 would be quite different from 0x7f7f7f7f for
instance, or a completely random number, so I don't want to judge ahead
of time.

> Nevertheless, I tested the patch and can confirm that there are no
> assertion failures anymore. 
> 
> I also ran it under ASAN and did not observe any issues.

Thanks for testing it.

> Would it make sense to add a test for this case from the bug report?

Sure, I would do that.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Saca el libro que tu religión considere como el indicado para encontrar la
oración que traiga paz a tu alma. Luego rebootea el computador
y ve si funciona" (Carlos Duclós)