Thread

Re: [PATCH] Fix psql tab completion for REPACK boolean options

Álvaro Herrera <alvherre@kurilemu.de> — 2026-05-13T12:41:13Z

On 2026-May-13, Fujii Masao wrote:

> On Tue, May 12, 2026 at 4:45 AM Baji Shaik <baji.pgdev@gmail.com> wrote:

> > The fix is to use pipe-separated alternatives (matching any one of
> > the keywords), consistent with how VACUUM handles the same pattern:
> >
> >     TailMatches("ANALYZE|CONCURRENTLY|VERBOSE")
> >
> > Patch attached.
> 
> Thanks for the patch! It looks good to me.
> Unless there are objections, I will commit it.

Yeah, looks good to me, thanks.

> BTW, I found that the boolean options for CLUSTER and REINDEX have
> the same issue, i.e., tab completion does not suggest boolean values
> such as ON and OFF. However, this has existed for a while, and adding
> those completions seems more like an improvement than a bug fix,
> so it should probably be handled separately during v20 development.

Fine with me.  I wouldn't have a problem saying it's a backpatchable
bugfix, but it's certainly not very high priority or criticality.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/