Horton

Re: Remove invalid SS2/SS3 handling from EUC-KR routines

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Henson Choi <assam258@gmail.com>
Cc: SungJun Jang <sjjang112233@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>, jian he <jian.universality@gmail.com>, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org, Tatsuo Ishii <ishii@postgresql.org>, thomas.munro@gmail.com
Date: 2026-05-13T05:14:50Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix encoding length for EUC_CN.

On Tue, May 12, 2026 at 08:39:04PM +0900, Henson Choi wrote:
> One small observation: after this patch, EUC-KR's mb routines become
> structurally identical to UHC's (1-2 byte Korean, IS_HIGHBIT_SET-only
> branch, maxmblen=2), which is a nice consistency win and arguably the
> right shape for "Korean 1-2 byte EUC".  Could be worth a one-liner in
> the commit message.

I unfortunately cannot read the PNG file added at the top of the
thread, and it is a bit hard to check what you are doing here.

I can however point out two things:
- the existence of src/test/locale/, which may be impacted by what you
are changing here.  Perhaps we should try to modernize a bit this
area, so as tests can become easier each time we try to change the
conversion tables?
- the proposed patch has zero regression tests.  This could be used to
check the behavior before *and* after the patch.
--
Michael