Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes

Álvaro Herrera <alvherre@kurilemu.de>

From: Álvaro Herrera <alvherre@kurilemu.de>

To: Chao Li <li.evan.chao@gmail.com>

Cc: Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-05-11T16:21:17Z

Lists: pgsql-hackers

On 2026-May-11, Chao Li wrote:

> > On May 10, 2026, at 06:38, Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > I think it would be a good idea to make identity_key_equal() not deform
> > all attributes, but instead only up to the last one it needs for the key
> > comparisons.
> 
> That’s true. Please see v3.

Thanks.  I did one further small change, namely to determine these last
attnums just once per run rather than once per tuple.  Pushed now.

Thanks for testing!

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/