Thread

Re: off-by-one in pg_repack index loop

Álvaro Herrera <alvherre@kurilemu.de> — 2026-05-04T18:02:01Z

On 2026-Apr-29, John Naylor wrote:

> On Tue, Apr 14, 2026 at 2:35 PM Lakshmi N <lakshmin.jhs@gmail.com> wrote:
> > if (unlikely(list_length(ind_oids_new) < pos))
> >      elog(ERROR, "list of new indexes too short");
> > ident_idx_new = list_nth_oid(ind_oids_new, pos);
> > break;
> 
> If we're going to change this, let's also get rid of the "unlikely",
> since it's just a noise word here -- see commit 913ec71d6.

Thanks, pushed that way.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Computing is too important to be left to men." (Karen Spärck Jones)