Horton

Re: multi-install PostgresNode fails with older postgres versions

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Mark Dilger <mark.dilger@enterprisedb.com>, Jehan-Guillaume de Rorthais <jgdr@dalibo.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-04-24T13:49:07Z
Lists: pgsql-hackers 
On 4/24/21 1:54 AM, Michael Paquier wrote:
> On Fri, Apr 23, 2021 at 08:10:01AM -0400, Andrew Dunstan wrote:
>> Yeah, I think it's ok for comparison purposes just to lump them all
>> together. Here's a patch that does that and some consequent cleanup.
>> Note we now cache the string rather than trying to reconstruct it.
> No objections from here to build the version string beforehand.  
>
>> +          (devel|(?:alpha|beta|rc)\d+)?   # dev marker - see version_stamp.pl
>> +		 !x);
> I have been playing with patch and version_stamp.pl, and that does the
> job.  Nice.


Thanks, pushed.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Teach PostgresVersion all the ways to mark non-release code

  2. Make PostgresNode version aware

  3. Avoid unfortunate IPC::Run path caching in PostgresNode

  4. Change pg_ctl to detect server-ready by watching status in postmaster.pid.