Re: proposal: schema variables

Laurenz Albe <laurenz.albe@cybertec.at>

From: Laurenz Albe <laurenz.albe@cybertec.at>

To: Pavel Stehule <pavel.stehule@gmail.com>

Cc: Erik Rijkers <er@xs4all.nl>, Michael Paquier <michael@paquier.xyz>, Amit Kapila <amit.kapila16@gmail.com>, DUVAL REMI <REMI.DUVAL@cheops.fr>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-10-24T08:29:02Z

Lists: pgsql-hackers, pgsql-performance

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move WAL sequence code into its own file
- a87987cafca6 19 (unreleased) cited
Add ExplainState argument to pg_plan_query() and planner().
- c83ac02ec730 19 (unreleased) cited
Don't include access/htup_details.h in executor/tuptable.h
- 1a8b5b11e48a 19 (unreleased) cited
Refactor to avoid code duplication in transformPLAssignStmt.
- b0fb2c6aa5a4 19 (unreleased) cited
Avoid including commands/dbcommands.h in so many places
- 325fc0ab14d1 19 (unreleased) cited
Restrict psql meta-commands in plain-text dumps.
- 71ea0d679543 19 (unreleased) cited
Split func.sgml into more manageable pieces
- 4e23c9ef65ac 19 (unreleased) cited
Fix squashing algorithm for query texts
- 0f65f3eec478 18.0 cited
EXPLAIN: Always use two fractional digits for row counts.
- 95dbd827f2ed 18.0 cited
Preliminary refactoring of plpgsql expression construction.
- a654af21ae52 18.0 cited
plpgsql: pure parser and reentrant scanner
- 7b27f5fd36cb 18.0 cited
Add some sanity checks in executor for query ID reporting
- 24f520594809 18.0 cited
Fix misleading error message context
- 4af123ad45bd 18.0 cited
Add macros for looping through a List without a ListCell.
- 14dd0f27d7cd 17.0 cited

Attachments

v20241024-0004-DISCARD-VARIABLES.patch (text/x-patch) patch v20241024-0004

... and here is a review for patch 4

I didn't change any code, just added the odd article to a comment.

While running the regression tests with "make installcheck", I noticed two problems:

  --- /home/laurenz/postgresql/src/test/regress/expected/session_variables.out    2024-10-24 11:14:06.717663613 +0300
  +++ /home/laurenz/postgresql/src/test/regress/results/session_variables.out 2024-10-24 11:15:37.999286228 +0300
  @@ -30,6 +30,7 @@
   GRANT ALL ON SCHEMA svartest TO regress_variable_owner;
   CREATE VARIABLE svartest.var1 AS int;
   CREATE ROLE regress_variable_reader;
  +ERROR:  role "regress_variable_reader" already exists

I suggest that patch 0001 should drop role "regress_variable_reader" again.

  @@ -107,7 +108,7 @@
   CONTEXT:  SQL function "sqlfx" statement 1
   SELECT plpgsqlfx(20);
   ERROR:  permission denied for session variable var1
  -CONTEXT:  SQL expression "$1 + var1"
  +CONTEXT:  PL/pgSQL expression "$1 + var1"

That looks like bit rot from your commit 4af123ad45.

Yours,
Laurenz Albe