Horton

Re: Fix typo 586/686 in atomics/arch-x86.h

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>, Tomas Vondra <tv@fuzzy.cz>, Jakub Wartak <jakub.wartak@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2026-05-07T21:46:08Z
Lists: pgsql-hackers 
On Thu, May 07, 2026 at 04:44:45PM -0500, Nathan Bossart wrote:
> On Thu, May 07, 2026 at 10:59:26PM +0200, Daniel Gustafsson wrote:
>> Attached is a patch against HEAD for this.  Reading your mail my interpretation
>> was that this was equally broken for MSVC even though the macro is correct
>> there, and we should remove both.  Was that a correct reading?
> 
> Yeah, atomics.h doesn't use the right macro for MSVC, so nothing in this
> file is compiled for MSVC anyway.  However, I suspect the proper fix is to
> make sure this file is included for MSVC.  Note that the other MSVC code in
> this file is similarly broken, but fortunately isn't used anywhere [0].

To be clear, I'm +1 on removing any 32-bit code in this file.  But the
64-bit stuff should probably be fixed.

-- 
nathan