Horton

Thread

Commits

  1. Remove non-existing variable reference in MSVC's Solution.pm

  1. [patch] remove strver's leftover from error message in Solution.pm

    Anton Voloshin <a.voloshin@postgrespro.ru> — 2021-06-25T17:47:50Z

    Hello,

in src/tools/msvc/Solution.pm (in the current master) there is a 
leftover from the past:
 >                 confess "Bad format of version: $self->{strver}\n";

strver has been gone since 8f4fb4c6 in 2019, so I suggest an obvious 
one-line fix in the patch attached:

diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index a7b8f720b55..fcb43b0ca05 100644
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -176,7 +176,7 @@ sub GenerateFiles

  			if ($package_version !~ /^(\d+)(?:\.(\d+))?/)
  			{
-				confess "Bad format of version: $self->{strver}\n";
+				confess "Bad format of version: $package_version\n";
  			}
  			$majorver = sprintf("%d", $1);
  			$minorver = sprintf("%d", $2 ? $2 : 0);

I think this should be backported to REL_13_STABLE, but not to 
REL_12_STABLE and earlier, where strver was still present.

-- 
Anton Voloshin,
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

  2. Re: [patch] remove strver's leftover from error message in Solution.pm

    Michael Paquier <michael@paquier.xyz> — 2021-06-26T00:37:47Z

    On Sat, Jun 26, 2021 at 12:47:50AM +0700, Anton Voloshin wrote:
> I think this should be backported to REL_13_STABLE, but not to REL_12_STABLE
> and earlier, where strver was still present.

Good catch!  I will take care of that.
--
Michael