Horton

Re: POC: postgres_fdw insert batching

Tomas Vondra <tomas.vondra@enterprisedb.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Ian Lawrence Barwick <barwick@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, "Andrey V. Lepikhov" <a.lepikhov@postgrespro.ru>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-02-15T16:32:43Z
Lists: pgsql-hackers 
On 2/5/21 2:55 AM, Ian Lawrence Barwick wrote:
> ...
> 
>     There's a minor typo in the doc's version of the
>     ExecForeignBatchInsert() declaration;
>     is:
> 
>         TupleTableSlot **
>         ExecForeignBatchInsert(EState *estate,
>                           ResultRelInfo *rinfo,
>                           TupleTableSlot **slots,
>                           TupleTableSlot *planSlots,
>                           int *numSlots);
> 
>     should be:
> 
>         TupleTableSlot **
>         ExecForeignBatchInsert(EState *estate,
>                           ResultRelInfo *rinfo,
>                           TupleTableSlot **slots,
>                           TupleTableSlot **planSlots,
>                           int *numSlots);
> 
>     (Trivial patch attached).
> 
> 
> Forgot to mention the relevant doc link:
> 
>    
> https://www.postgresql.org/docs/devel/fdw-callbacks.html#FDW-CALLBACKS-UPDATE
> <https://www.postgresql.org/docs/devel/fdw-callbacks.html#FDW-CALLBACKS-UPDATE>
> 

Thanks, I'll get this fixed.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Fix tuple routing to initialize batching only for inserts

  2. Fix pointer type in ExecForeignBatchInsert SGML docs

  3. Fix initialization of FDW batching in ExecInitModifyTable

  4. Implement support for bulk inserts in postgres_fdw