Re: pgbench: make verbose error messages thread-safe

On Fri, Apr 24, 2026 at 03:26:03PM +0900, Fujii Masao wrote:
> Attached patch fixes this issue by changing printVerboseErrorMessages()
> to use a local PQExpBufferData instead of a static one. Thoughts?

That looks like an oversight of 4a39f87acd6e to me.  A static buffer
in this context is not adapted.

> Since this issue was introduced in v15, the patch should be
> backpatched to v15 if accepted.

This forces a new allocation for each message printed vs a set of
resets after one allocation is done.  This change is not going to be
entirely free as done in the patch, so should we worry about that?
Perhaps it would be cheaper to allocate a PQExpBuffer in each CState,
and just reuse it in this routine?
--
Michael