Re: remove unnecessary explicit type conversion (to char) for appendStringInfoChar function calls

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-13T14:14:15Z
Lists: pgsql-hackers
On 2025-04-13 Su 8:12 AM, Álvaro Herrera wrote:
> On 2025-Apr-12, Andrew Dunstan wrote:
>
>> Seems odd that this one is necessary at all. Doesn't a StringInfo always
>> have a trailing null byte?
> AFAICT what this is doing that's significant, is increment StringInfo->len.
> Before doing it, the NUL byte is not part of the message; afterwards it
> is.
>


That make sense, but then it would be nice to have the accompanying 
comment a bit clearer.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com