Horton
Menu

Re: Use correct macro for accessing offset numbers.

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Kirill Reshke <reshkekirill@gmail.com>, li carol <carol.li2025@outlook.com>, Roman Khapov <rkhapov@yandex-team.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, zengman <zengman@halodbtech.com>
Date: 2026-04-27T23:26:44Z
Lists: pgsql-hackers 
On Fri, Apr 24, 2026 at 10:23:23AM +0200, Peter Eisentraut wrote:
> The thread [0] is proposing a patch to change these things in the opposite
> direction, effectively reverting commit 6dcfac9696c.

Thanks for the poke.  This qualifies as an open item assigned to me, I
guess.  I'll double-check the whole and reply on the other thread
where the patch has been posted at [1].

> The real problem here is that offset values that are uint32 are being output
> via the SQL type smallint, which can't handle the whole set of values, but
> this is probably not a problem in practice.

Will check all that.

[1]: https://www.postgresql.org/message-id/CAJ7c6TMcGu8qmRe1gZfJ-gOzVnZq-t%3Dfwn-UuyStx1w6ZyydMw%40mail.gmail.com
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust some incorrect *GetDatum() macros

  2. Use more consistent *GetDatum() macros for some unsigned numbers