Horton
Menu

Re: some extra warnings from MSVC

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-04-19T22:18:37Z
Lists: pgsql-hackers 
On Sat, Apr 11, 2026 at 10:09:58AM -0400, Tom Lane wrote:
> I think it'd be a good idea to warn even if we can't make gcc do that.
> I think Windows is the only 64-bit platform we deal with where long
> is just 32 bits, so covering the case in MSVC will expose bugs we
> would not notice otherwise.

Interesting issue.  I did not notice this thread until 9018c7d37bb4.
Please do not hesitate to add me in CC in the future, as 13b935cd521
has my fingerprints.  Thanks for fixing the issue.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix 64-bit shifting in dynahash.c

  2. MSVC: Turn missing function declaration into an error

  3. Add missing include

  4. Add backtrace support for Windows using DbgHelp API

  5. Change dynahash.c and hsearch.h to use int64 instead of long