Horton

Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2020-07-08T06:22:36Z
Lists: pgsql-hackers

Attachments


On 2020/07/08 11:55, torikoshia wrote:
> On 2020-07-08 11:15, Fujii Masao wrote:
>> On 2020/07/08 11:02, torikoshia wrote:
>>> Hi,
>>>
>>> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
>>> but it seems that should be "XLogSegNo" because this variable is
>>> segment number.
>>>
>>> How do you think?
>>
>> I agree that using XLogRecPtr for slot_keep_segs is incorrect.
>> But this variable indicates the number of segments rather than
>> segment no, uint64 seems better. Thought?
> 
> That makes sense.
> The number of segments and segment number are different.

Yes, so patch attached. I will commit it later.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Fix incorrect variable datatype.