Horton

Re: Remove traces of long in dynahash.c

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chao Li <li.evan.chao@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-27T08:00:16Z
Lists: pgsql-hackers 
On 22.08.25 07:09, Michael Paquier wrote:
> An extra thing is a suggested change for pg_nextpower2_32(), to use a
> uint64 instead of a uint32 as argument, which is caused by
> next_pow2_int64() and next_pow2_int(), that both used int64
> previously.

That seems highly confusing.  What is the meaning of the "32" then?

If you need 64-bit behavior, use the variant with "64" in the name.

Commits

  1. Remove dynahash.h

  2. Replace callers of dynahash.h's my_log() by equivalent in pg_bitutils.h

  3. Change dynahash.c and hsearch.h to use int64 instead of long