Re: select_common_typmod

On 2020-10-26 10:05, Heikki Linnakangas wrote:
>> There might have been a tiny bug in transformValuesClause() because
>> while consolidating the typmods it does not take into account whether
>> the types are actually the same (as more correctly done in
>> transformSetOperationTree() and buildMergedJoinVar()).
> 
> Hmm, it seems so, but I could not come up with a test case to reach that
> codepath. I think you'd need to create two types in the same
> typcategory, but with different and incompatible typmod formats.

Yeah, something like that.

> The patch also adds typmod resolution for hypothetical ordered-set
> aggregate arguments. I couldn't come up with a test case that would
> tickle that codepath either, but it seems like a sensible change. You
> might want to mention it in the commit message though.

OK, committed with that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services