Horton

Re: Is it useful to record whether plans are generic or custom?

torikoshia <torikoshia@oss.nttdata.com>

View thread View on postgr.es
From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tatsuro.yamada.tf@nttcom.co.jp, sunchengxi@highgo.com, pgsql-hackers@postgresql.org, pavel.stehule@gmail.com, legrand_legrand@hotmail.com
Date: 2021-04-05T09:01:48Z
Lists: pgsql-hackers 
On 2021-03-26 17:46, Fujii Masao wrote:
> On 2021/03/26 0:33, torikoshia wrote:
>> On 2021-03-25 22:14, Fujii Masao wrote:
>>> On 2021/03/23 16:32, torikoshia wrote:
>>>> On 2021-03-05 17:47, Fujii Masao wrote:
>>>> 
>>>> Thanks for your comments!
>>> 
>>> Thanks for updating the patch!
>>> 
>>> PostgreSQL Patch Tester reported that the patched version failed to 
>>> be compiled
>>> at Windows. Could you fix this issue?
>>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.131238
>>> 
>> 
>> It seems PGDLLIMPORT was necessary..
>> Attached a new one.
> 
> Thanks for updating the patch!
> 
> In my test, generic_calls for a utility command was not incremented
> before PL/pgSQL function was executed. Maybe this is expected behavior.
> But it was incremented after the function was executed. Is this a bug?
> Please see the following example.

Thanks for reviewing!

It's a bug and regrettably it seems difficult to fix it during this
commitfest.

Marked the patch as "Withdrawn".


Regards,

Commits

  1. Add generic_plans and custom_plans fields into pg_prepared_statements.