Re: Ensure that STDERR is empty during connect_ok

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2022-02-02T16:12:27Z
Lists: pgsql-hackers
On 2/2/22 11:01, Dagfinn Ilmari Mannsåker wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>
>>> While I prefer to not plan at all and instead run done_testing(),
>>> doing that consistently is for another patch, keeping this with the
>>> remainder of the suites.
>> +1 to that too, counting the tests is a pretty useless exercise.
> Rather than waiting for Someone™ to find a suitably-shaped tuit to do a
> whole sweep converting everything to done_testing(), I think we should
> make a habit of converting individual scripts whenever a change breaks
> the count.


Or when anyone edits a script, even if the number of tests doesn't get
broken.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




Commits

  1. Ensure that STDERR is empty in connect_ok tests

  2. Require version 0.98 of Test::More for TAP tests