Horton
Menu

Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Andreas Karlsson <andreas@proxel.se>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2026-04-08T23:54:49Z
Lists: pgsql-hackers 
On Wed, Apr 08, 2026 at 11:28:13AM +0900, Michael Paquier wrote:
> Well, the main point being to be able to detect breakages more
> carefully, I am still curious to see where this experiment will lead
> us, so I'd be content to leave the code as-is on HEAD, adjusting
> things based on what I have sent in my previous email.  If we are able
> to detect one problem, at least, that would be a win for me, and the
> solution of HEAD is much better than creating fake routines to tell
> ABI detection libraries about the existence of the enum, at least
> that's my take.

The footprint of syscache.h has been reduced in src/include/ as of
e0fa5bd14656, for now, after more tweaks applied to the format of the
file generated due to the new ifndef.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reduce presence of syscache.h in src/include/

  2. Switch SysCacheIdentifier to a typedef enum

  3. Add concept of invalid value to SysCacheIdentifier