Re: Adding locks statistics

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andres Freund <andres@anarazel.de>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Jeff Davis <pgsql@j-davis.com>, Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2026-04-06T06:34:44Z

Lists: pgsql-hackers

Attachments

0001-Fix-detach-timing-problem-in-lock-stats-test.patch (text/plain) patch 0001

On Mon, Apr 06, 2026 at 03:19:57PM +0900, Michael Paquier wrote:
> Now looking at it, and for the reason why 010 for concurrent indexes
> does not complain..

This one was a simple puzzle: there was a race condition between the
detach done by a local point and the wait/detach sequence.  As we want
a detach, dropping the local point is proving to work here.

I am going to do a few more runs to gain some more confidence.
Bertrand, could you confirm please?
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix injection point detach timing problem in TAP test for lock stats
- 3284e3f63cf0 19 (unreleased) landed
Use single LWLock for lock statistics in pgstats
- 404a17c155ac 19 (unreleased) landed
Add tests for lock statistics, take two
- 557a9f1e3e62 19 (unreleased) landed
Remove isolation test lock-stats
- 7c64d56fd976 19 (unreleased) landed
Avoid including clog.h in proc.h
- f227b7b20c36 19 (unreleased) landed
Don't include storage/lock.h in so many headers
- 2102ebb1953f 19 (unreleased) landed
Add support for lock statistics in pgstats
- 4019f725f5d4 19 (unreleased) landed
Move some code blocks in lock.c and proc.c
- a90d86518243 19 (unreleased) landed
Move declarations related to locktags from lock.h to new locktag.h
- 322bab79744d 19 (unreleased) landed