Re: max_slot_wal_keep_size and wal_keep_segments

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2020-07-01T12:50:56Z
Lists: pgsql-hackers

On 2020/07/01 12:26, Alvaro Herrera wrote:
> On 2020-Jun-30, Fujii Masao wrote:
> 
>> Hi,
>>
>> When I talked about max_slot_wal_keep_size as new feature in v13
>> at the conference, I received the question like "Why are the units of
>> setting values in max_slot_wal_keep_size and wal_keep_segments different?"
>> from audience. That difference looks confusing for users and
>> IMO it's better to use the same unit for them. Thought?
> 
> Do we still need wal_keep_segments for anything?

Yeah, personally I like wal_keep_segments because its setting is very
simple and no extra operations on replication slots are necessary.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Commits

  1. doc: Mention the rename of wal_keep_segments GUC in release note.

  2. Rename wal_keep_segments to wal_keep_size.