Horton
Menu

Re: [PATCH] Fix: Partitioned parent index remains invalid after child indexes are repaired

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Haibo Yan <tristan.yim@gmail.com>, Mohamed ALi <moali.pg@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-04-14T16:05:38Z
Lists: pgsql-hackers 
On Tue, Apr 14, 2026 at 07:18:33AM +0900, Michael Paquier wrote:
> On Sat, Apr 11, 2026 at 11:10:54AM -0500, Sami Imseih wrote:
>> Would the right solution here be to try to have the ATTACH PARTITION  check if
>> the parent index is not valid, then validatePartitionedIndex() ?
> 
> This may be a backpatchable thing, even if it requires one to detach
> one partition before attaching it again, or attach a fake partition to
> force a flip of the flag, before detaching this fake partition.

Actually no.  Yesterday I was looking at that from the angle of using
ALTER TABLE for the job, that requires a partition bound.  Sami has
mentioned me that a repeated ALTER INDEX .. ATTACH PARTITION does not
fail when repeated, so we could just rely on that and enforce a
round of indisvalid across the partitioned index we are working on.

Could you write a patch?  It would be better to have tests with
multiple levels, at least, with a partitioned table being a leaf of
another partitioned table.  I am sure you get the picture, the point
being to recurse across multiple levels.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Mention validation attempt during ALTER INDEX .. ATTACH PARTITION

  2. Allow ALTER INDEX .. ATTACH PARTITION to validate a parent index