Re: Adding locks statistics

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: Álvaro Herrera <alvherre@kurilemu.de>, Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>, Greg Sabino Mullane <htamfids@gmail.com>, "L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>

Date: 2026-03-24T03:15:05Z

Lists: pgsql-hackers

On Mon, Mar 23, 2026 at 08:18:05AM +0000, Bertrand Drouvot wrote:
> It looks like that aio_funcs.c does not need lock.h (reported by include-what-you-use).
> If we remove its direct include, it's still indirectly included through proc.h
> though. But I think that removing its direct include makes sense as it's not
> needed at all.
> 
> If we still need to discuss about those lock.h related changes, maybe it's
> worth creating a dedicated thread?

This patch set is related to an entirely different topic than what we
are discussing, so yes, a different thread would be adapted.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix injection point detach timing problem in TAP test for lock stats
- 3284e3f63cf0 19 (unreleased) landed
Use single LWLock for lock statistics in pgstats
- 404a17c155ac 19 (unreleased) landed
Add tests for lock statistics, take two
- 557a9f1e3e62 19 (unreleased) landed
Remove isolation test lock-stats
- 7c64d56fd976 19 (unreleased) landed
Avoid including clog.h in proc.h
- f227b7b20c36 19 (unreleased) landed
Don't include storage/lock.h in so many headers
- 2102ebb1953f 19 (unreleased) landed
Add support for lock statistics in pgstats
- 4019f725f5d4 19 (unreleased) landed
Move some code blocks in lock.c and proc.c
- a90d86518243 19 (unreleased) landed
Move declarations related to locktags from lock.h to new locktag.h
- 322bab79744d 19 (unreleased) landed