Re: pg_resetwal tests, logging, and docs update

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2023-10-29T17:23:00Z

Lists: pgsql-hackers

Attachments

v3-0001-doc-pg_resetwal-Add-comments-how-the-multipliers-.patch (text/plain) patch v3-0001
v3-0002-pg_resetwal-Add-more-tests-and-test-coverage.patch (text/plain) patch v3-0002

On 29.09.23 10:02, Peter Eisentraut wrote:
> On 26.09.23 17:19, Aleksander Alekseev wrote:
>>> Attached is an updated patch set where I have split the changes into
>>> smaller pieces.  The last two patches still have some open questions
>>> about what certain constants mean etc.  The other patches should be 
>>> settled.
>>
>> The patches 0001..0005 seem to be ready and rather independent. I
>> suggest merging them and continue discussing the rest of the patches.
> 
> I have committed 0001..0005, and also posted a separate patch to discuss 
> and correct the behavior of the -c option.  I expect that we will carry 
> over this patch set to the next commit fest.

Here are updated versions of the remaining patches.  I took out the 
"FIXME" notes about the multipliers applying to the -c option and 
replaced them by gentler comments.  I don't intend to resolve those 
issues here.

Commits

doc: pg_resetwal: Add comments how the multipliers are derived
- 6ceec8a1fe7a 17.0 landed
pg_resetwal: Add more tests and test coverage
- 7b5275eec3a5 17.0 landed
More consistent behavior of GetDataDirectoryCreatePerm on Windows
- 2c7c6c417fe6 17.0 landed
doc: Improve documentation about pg_resetwal -f option
- 5f1b00e64aee 17.0 landed
pg_resetwal: Use frontend logging API
- a11d8e10f226 17.0 landed
pg_resetwal: Regroup --help output
- b5da1b3a939a 17.0 landed
pg_resetwal: Improve error with wrong/missing data directory
- 1d863c250461 17.0 landed
pg_resetwal: Update an obsolete comment
- 7273945cafa7 17.0 landed