Horton

Re: postgres_fdw: using TABLESAMPLE to collect remote sample

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-22T00:36:49Z
Lists: pgsql-hackers 

On 2022/02/18 22:28, Tomas Vondra wrote:
> Hi,
> 
> here's a slightly updated version of the patch series.

Thanks for updating the patches!


> The 0001 part
> adds tracking of server_version_num, so that it's possible to enable
> other features depending on it.

Like configure_remote_session() does, can't we use PQserverVersion() instead of implementing new function GetServerVersion()?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Check relkind before using TABLESAMPLE in postgres_fdw

  2. Fix stale comment about sample_frac adjustment