Horton

Re: Terminate the idle sessions

Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

View thread View on postgr.es
From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Li Japin <japinli@hotmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>
Cc: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, "bharath.rupireddyforpostgres@gmail.com" <bharath.rupireddyforpostgres@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2020-12-01T13:55:49Z
Lists: pgsql-hackers 
On 25.11.2020 05:18, Li Japin wrote:
>
>
>
>> On Nov 24, 2020, at 11:20 PM, David G. Johnston 
>> <david.g.johnston@gmail.com <mailto:david.g.johnston@gmail.com>> wrote:
>>
>> On Mon, Nov 23, 2020 at 11:22 PM Li Japin <japinli@hotmail.com 
>> <mailto:japinli@hotmail.com>> wrote:
>>
>>
>>     How about use “foreign-data wrapper” replace “postgres_fdw”?
>>
>>
>> I don't see much value in avoiding mentioning that specific term - my 
>> proposal turned it into an example instead of being exclusive.
>>
>>
>>     -         This parameter should be set to zero if you use some
>>     connection-pooling software,
>>     -         or pg servers used by postgres_fdw, because connections
>>     might be closed unexpectedly.
>>     +         This parameter should be set to zero if you use
>>     connection-pooling software,
>>     +         or <productname>PostgreSQL</productname> servers
>>     connected to using foreign-data
>>     +         wrapper, because connections might be closed unexpectedly.
>>              </para>
>>
>>
>> Maybe:
>>
>> + or your PostgreSQL server receives connection from postgres_fdw or 
>> similar middleware.
>> + Such software is expected to self-manage its connections.
>
> Thank you for your suggestion and patient! Fixed.
>
> ```
> +        <para>
> +         This parameter should be set to zero if you use 
> connection-pooling software,
> +         or <productname>PostgreSQL</productname> servers connected 
> to using postgres_fdw
> +         or similar middleware (such software is expected to 
> self-manage its connections),
> +         because connections might be closed unexpectedly.
> +        </para>
> ```
>
> --
> Best regards
> Japin Li
>

Status update for a commitfest entry.
As far as I see, all recommendations from reviewers were addressed in 
the last version of the patch.

It passes CFbot successfully, so I move it to Ready For Committer.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Rethink SQLSTATE code for ERRCODE_IDLE_SESSION_TIMEOUT.

  2. Improve commentary in timeout.c.

  3. Add idle_session_timeout.

  4. Improve timeout.c's handling of repeated timeout set/cancel.