Horton

Re: More issues with expressions always false (no patch)

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: Ranier Vilela <ranier.vf@gmail.com>, pgsql-hackers@lists.postgresql.org, peter.eisentraut@2ndquadrant.com
Date: 2019-12-20T15:35:25Z
Lists: pgsql-hackers

Attachments

On 12/20/19 1:54 AM, Andreas Karlsson wrote:
> On 12/20/19 1:01 AM, Ranier Vilela wrote:> First case:
>> Third case:
>> \ src \ backend \ utils \ cache \ relcache.c (line 5190)
>> if (relation-> rd_pubactions)
>>
>> It will never be executed, because if relation-> rd_pubactions is 
>> true, the function returns on line 5154.
> 
> I have not looked into this one in detail, but the free at line 5192 
> looks like potentially dead code.

I have looked at it now and it seems like this code has been dead since 
the function was originally implemented in 665d1fad99e.

Peter, what do you think?

Andreas

Commits

  1. Correctly re-use hash tables in buildSubPlanHash().

  2. Reset, not recreate, execGrouping.c style hashtables.