Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

Shinya Kato <shinya11.kato@oss.nttdata.com>

From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: katouknl <katouknl@oss.nttdata.com>
Cc: Suraj Khamkar <khamkarsuraj.b@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-10-15T04:29:12Z
Lists: pgsql-hackers
On 2021-10-14 14:30, katouknl wrote:
>> It is very good, but it seems to me that there are some tab-completion
>> missing in COMMENT command.
>> For example,
>> - CONSTRAINT ... ON DOMAIN
>> - OPERATOR CLASS
>> - OPERATOR FAMILY
>> - POLICY ... ON
>> - [PROCEDURAL]
>> - RULE ... ON
>> - TRIGGER ... ON
>> 
>> I think these tab-comletion also can be improved and it's a good
>> timing for that.
> 
> Thank you for the comments!
> 
> I fixed where you pointed out.
Thank you for the update!
I tried "COMMENT ON OPERATOR ...", and an operator seemed to be 
complemented with double quotation marks.
However, it caused the COMMENT command to fail.
---
postgres=# COMMENT ON OPERATOR "+" (integer, integer) IS 'test_fail';
ERROR:  syntax error at or near "("
LINE 1: COMMENT ON OPERATOR "+" (integer, integer) IS 'test_fail';
postgres=# COMMENT ON OPERATOR + (integer, integer) IS 'test_success';
COMMENT
---

So, I think as with \do command, you do not need to complete the 
operators.
Do you think?


-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Commits

  1. Improve psql tab completion for COMMENT