Horton

Re: [PATCH] Add min() and max() aggregate functions for xid8

Ken Kato <katouknl@oss.nttdata.com>

View thread View on postgr.es
From: Ken Kato <katouknl@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-02-05T01:46:05Z
Lists: pgsql-hackers

Attachments

> +	PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) >
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
> 
> Shouldn't we use FullTransactionIdFollows() to compare those two fxid
> values here, instead?
> 
> +	PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) <
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
> 
> Shouldn't we use FullTransactionIdPrecedes() to compare those two fxid
> values here, instead?
> 
> Could you add the regression tests for those min() and max() functions 
> for xid8?

Thank you for the comments.
I sent my old version of patch by mistake.
This is the updated one.

Best wishes

-- 
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Add min() and max() aggregates for xid8.