Re: Add pg_stat_recovery system view

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Xuneng Zhou <xunengzhou@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-03-06T04:00:25Z

Lists: pgsql-hackers

On Thu, Mar 05, 2026 at 09:01:35PM +0800, Xuneng Zhou wrote:
> Here is the updated patch set. Please take a look.

Thanks.  It was mostly fine, still:
- The extra mention of ROLE_PG_READ_ALL_STATS was not necessary.  We
already have one at the top of the section.
- After sleeping on it, I have decided to keep recoveryLastXTime,
partially because we have a system function to retrieve it already.
- There was a refactoring piece possible when we switch a
RecoveryPauseState to a non-translatable string, which I have applied
separately.
- Added one test with pg_stat_recovery checked on a standby.
--
Michael

Commits

Fix order of columns in pg_stat_recovery
- 2d4ead6f4bd0 19 (unreleased) landed
Add system view pg_stat_recovery
- 01d485b142e4 19 (unreleased) landed
Refactor code retrieving string for RecoveryPauseState
- 42a12856a6a0 19 (unreleased) landed
Move definition of XLogRecoveryCtlData to xlogrecovery.h
- 5f8124a0cf33 19 (unreleased) landed