Horton

Re: pg_dumpall --roles-only interact with other options

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, jian he <jian.universality@gmail.com>, wangpeng <215722532@qq.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-03-03T18:50:46Z
Lists: pgsql-hackers

Attachments

Here's what I have staged for commit.  A few notes:

* I moved the new function to option_utils.c and added a macro that takes
care of figuring out the number of arguments.

* I removed the derivative flags.  I know I lobbied for those, but they
seemed out of place for this patch.  Maybe we can add them separately.

* I limited the number of new tests to one per call to
check_mut_excl_opts().  I didn't see much benefit from testing everything
exhaustively.

-- 
nathan

Commits

  1. pg_dumpall: Fix handling of conflicting options.

  2. pg_dump: Add dumpSchema and dumpData derivative flags.