Re: Remove distprep
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-14T08:56:26Z
Lists: pgsql-hackers
Attachments
- v3-0001-Remove-distprep.patch (text/plain) patch v3-0001
On 14.07.23 09:54, Peter Eisentraut wrote: >>> diff --git a/src/tools/pginclude/cpluspluscheck >>> b/src/tools/pginclude/cpluspluscheck >>> index 4e09c4686b..287395887c 100755 >>> --- a/src/tools/pginclude/cpluspluscheck >>> +++ b/src/tools/pginclude/cpluspluscheck >>> @@ -134,6 +134,9 @@ do >>> test "$f" = src/interfaces/ecpg/preproc/preproc.h && continue >>> test "$f" = src/test/isolation/specparse.h && continue >>> >>> + # FIXME >>> + test "$f" = src/backend/utils/adt/jsonpath_internal.h && continue >>> + >>> # ppport.h is not under our control, so we can't make it >>> standalone. >>> test "$f" = src/pl/plperl/ppport.h && continue >> >> Hm, what's that about? > > Don't remember ... ;-) I removed this. Ah, there was a reason. The headerscheck and cpluspluscheck targets need jsonpath_gram.h to be built first. Which previously happened indirectly somehow? I have fixed this in the new patch version. I also fixed the issue that Álvaro reported nearby.
Commits
-
Fix make build on MinGW
- 58445651dbc6 17.0 landed
-
Stop generating plain-text INSTALL instructions.
- e2b73f4a4de6 17.0 landed
-
Remove distprep
- 721856ff24b3 17.0 landed