Horton

Re: snapbuild woes

Erik Rijkers <er@xs4all.nl>

View thread View on postgr.es
From: Erik Rijkers <er@xs4all.nl>
To: Andres Freund <andres@anarazel.de>
Cc: David Steele <david@pgmasters.net>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Craig Ringer <craig@2ndquadrant.com>, pgsql-hackers-owner@postgresql.org
Date: 2017-04-08T14:29:10Z
Lists: pgsql-hackers 
On 2017-04-08 15:56, Andres Freund wrote:
> On 2017-04-08 09:51:39 -0400, David Steele wrote:
>> On 3/2/17 7:54 PM, Petr Jelinek wrote:
>> >
>> > Yes the copy patch needs rebase as well. But these ones are fine.
>> 
>> This bug has been moved to CF 2017-07.
> 
> FWIW, as these are bug-fixes that need to be backpatched, I do plan to
> work on them soon.
> 

CF 2017-07 pertains to postgres 11, is that right?

But I hope you mean to commit these snapbuild patches before the 
postgres 10 release?  As far as I know, logical replication is still 
very broken without them (or at least some of that set of 5 patches - I 
don't know which ones are essential and which may not be).

If it's at all useful I can repeat tests to show how often current 
master still fails (easily 50% or so failure-rate).

This would be the pgbench-over-logical-replication test that I did so 
often earlier on.

thanks,

Erik Rijkers

Commits

  1. Fix thinko introduced in 2bef06d516460 et al.

  2. Avoid superfluous work for commits during logical slot creation.

  3. Fix race condition leading to hanging logical slot creation.

  4. Don't use on-disk snapshots for exported logical decoding snapshot.

  5. Preserve required !catalog tuples while computing initial decoding snapshot.