Re: enable pg_stat_statements to track rows processed by REFRESH MATERIALIZED VIEW

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Yuki Seino <seinoyu@oss.nttdata.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-11-02T11:01:40Z
Lists: pgsql-hackers

On 2020/11/02 14:02, Yuki Seino wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> +1.
> I checked the patch and there were no problems.

+		PG_END_TRY();
+		SetQueryCompletion(qc, CMDTAG_REFRESH_MATERIALIZED_VIEW, processed);

Isn't it better to call SetQueryCompletion() in ExecRefreshMatView()
instead of ProcessUtilitySlow() (e.g., ExecCreateTableAs() does)?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Commits

  1. pg_stat_statements: track number of rows processed by REFRESH MATERIALIZED VIEW.