Re: [PATCH] Add CANONICAL option to xmlserialize

Jim Jones <jim.jones@uni-muenster.de>

From: Jim Jones <jim.jones@uni-muenster.de>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Pavel Stehule <pavel.stehule@gmail.com>, Chapman Flack <chap@anastigmatix.net>, vignesh C <vignesh21@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Vik Fearing <vik@postgresfriends.org>

Date: 2025-03-21T09:47:09Z

Lists: pgsql-hackers

Attachments

v16-0001-Add-xmlcanonicalize-function.patch (text/x-patch) patch v16-0001

While reviewing another patch, I noticed that the keep_comments argument
was missing a default value. To allow calling the function with only the
XML argument, I've added DEFAULT true to keep_comments.

SELECT xmlcanonicalize(xmldoc);

Updated patch (v16) attached.

Best, Jim