Horton

Re: Re: [proposal] Add an option for returning SQLSTATE in psql error message

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: didier <did447@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, Pavel Stěhule <pavel.stehule@gmail.com>, andrew@tao11.riddles.org.uk, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-03-21T18:01:15Z
Lists: pgsql-hackers 
On 2/4/19 5:54 AM, Michael Paquier wrote:
> On Mon, Jan 07, 2019 at 10:44:24PM +0100, didier wrote:
>> On Sat, Jan 5, 2019 at 6:30 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>>> Why are you not including a test for \set VERBOSITY verbose?
>>>
>>> Stability of the output would be a problem ...
>>>
>>> Yes it could moreover the functionality wasn't tested before.
>> Should I add one ?
> 
> Unpredictible outputs mean more maintenance and more alternate
> outputs.  I have moved the patch to next CF, still ready for
> committer.

What do you think, Peter?  Is the extra test valuable or will it cause 
unpredictable outputs as Tom and Michael predict?

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Add a "SQLSTATE-only" error verbosity option to libpq and psql.