Re: Add pg_stat_recovery system view

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Xuneng Zhou <xunengzhou@gmail.com>, yangyz <1197620467@qq.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-03-09T06:06:20Z
Lists: pgsql-hackers
On Mon, Mar 09, 2026 at 01:20:45PM +0800, Chao Li wrote:
>> [1] https://www.postgresql.org/docs/devel/error-message-reporting.html
> 
> Would it make sense to mention this distinction in the header
> comments for ereport and elog in the code? For these logging APIs, I
> think developers are often more likely to read the code comments
> than the documentation.

As of the link already mentioned:
"Therefore, elog should be used only for internal errors .."
--
Michael

Commits

  1. Fix order of columns in pg_stat_recovery

  2. Add system view pg_stat_recovery

  3. Refactor code retrieving string for RecoveryPauseState

  4. Move definition of XLogRecoveryCtlData to xlogrecovery.h