Horton
Menu

Re: Avoid resource leak (src/bin/pg_dump/pg_dumpall.c)

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: yangyz <1197620467@qq.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Ranier Vilela <ranier.vf@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-09T04:17:13Z
Lists: pgsql-hackers 
On Mon, Mar 09, 2026 at 11:21:35AM +0800, yangyz wrote:
> I think it should be modified.
> 
> Move createPQExpBuffer inside the conditional block to match its destroy counterpart.
> This improves code clarity and satisfies static analyzers, even though the actual memory
> leak is minimal in practice.

destroyPQExpBuffer() is called for each tuple from pg_database except
if dealing with "template{0,1}" or "postgres".  It means that we would
just leak a few bytes for these three cases.  I agree that the
variable declaration can be placed better, but it's really not worth
bothering in this context.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_dumpall: simplify coding of dropDBs()