Re: Special-case executor expression steps for common combinations

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>

Date: 2024-07-22T12:33:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add special case fast-paths for strict functions
- d35d32d7112b 18.0 landed
Replace EEOP_DONE with special steps for return/no return
- 8dd7c7cd0a26 18.0 landed

Attachments

0001-Suggested-style-changes.patch (text/x-patch) patch 0001

On 7/4/24 6:26 PM, Daniel Gustafsson wrote:
>> 2) We could generate functions which return void rather than NULL and therefore not have to do a return at all but I am not sure that small optimization and extra clarity would be worth the hassle. The current approach with adding Assert() is ok with me. Daniel, what do you think?
> 
> I'm not sure that would move the needle enough to warrant the extra complexity.
> It could be worth pursuing, but it can be done separately from this.

Agreed.

I looked some more at the patch and have a suggestion for code style. 
Attaching the diff. Do with them what you wish, for me they make to code 
easier to read.

Andreas