Horton

Re: Add expressions to pg_restore_extended_stats()

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Tender Wang <tndrwang@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas@vondra.me>
Date: 2026-03-09T00:07:04Z
Lists: pgsql-hackers 
On Sat, Mar 07, 2026 at 01:17:39AM -0500, Corey Huinker wrote:
> Fairly close +307, -603

Thanks for the patches.  I have tweaked a couple of comments, and
applied them after merging the whole together.  I have also spent the
time checking things by breaking some of the internal logic of the
restore functions, to see if diffs were correctly showing up.

One thing I was wondering is if the flat functions should call the
view, but at the end I guess that it does not matter much as long as
each query is grouped close to the other.  There is no need to expose
attrelid in the view, information we do not want to show in the type
of the view anyway.
--
Michael

Commits

  1. Refactor tests for catalog diff comparisons in stats_import.sql

  2. Fix typo in stats_import.sql

  3. Add support for "exprs" in pg_restore_extended_stats()

  4. Add information about range type stats to pg_stats_ext_exprs

  5. Fix comment in extended_stats_funcs.c