Horton
Menu

Re: recovery.signal not cleaned up when both signal files are present

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Nikolay Samokhvalov <nik@postgres.ai>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-10T04:52:43Z
Lists: pgsql-hackers 
On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
> +1 to apply this change only to the master branch. Patch attached.

It looks like something we should have a test for, at least..

+    /*
+     *
+     * If both signal files are present, standby signal file takes precedence.
+     * If neither is present then we won't enter archive recovery.
+     */

This comment's format is incorrect.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove recovery.signal at recovery end when both signal files are present.