Horton

Re: Add expressions to pg_restore_extended_stats()

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Tender Wang <tndrwang@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas@vondra.me>
Date: 2026-02-04T06:23:59Z
Lists: pgsql-hackers 
On Wed, Feb 04, 2026 at 01:13:05AM -0500, Corey Huinker wrote:
>> Hmm.  I am not sure, that depends.  How much additional information
>> would these extra parameter bring to the errors generated in
>> statatt_build_stavalues().
> 
> Just the index of which expression and the name of the key that fed in the
> offending value string.

Okay.  It really sounds to me like an ErrorContextCallback would help
you here.  I don't see a need to complicate statatt_build_stavalues(),
but my intuition can also be wrong.
--
Michael

Commits

  1. Refactor tests for catalog diff comparisons in stats_import.sql

  2. Fix typo in stats_import.sql

  3. Add support for "exprs" in pg_restore_extended_stats()

  4. Add information about range type stats to pg_stats_ext_exprs

  5. Fix comment in extended_stats_funcs.c