Re: pgsql: Separate RecoveryConflictReasons from procsignals

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

To: Heikki Linnakangas <heikki.linnakangas@iki.fi>

Cc: pgsql-committers@lists.postgresql.org

Date: 2026-02-10T15:19:09Z

Lists: pgsql-hackers

Hi,

On Tue, Feb 10, 2026 at 02:32:37PM +0000, Heikki Linnakangas wrote:
> Separate RecoveryConflictReasons from procsignals
> 
> Share the same PROCSIG_RECOVERY_CONFLICT flag for all recovery
> conflict reasons. To distinguish, have a bitmask in PGPROC to indicate
> the reason(s).

I did not look at the thread, so sorry to be late, but that makes the size of PGPROC
going from 832 to 840 bytes, so not a multiple of 64 anymore. Is that something
to worry about? (same kind of discussion in [1]).

[1]: https://postgr.es/m/tw53roer2j4quxh7vlyv62drc5fo6c6zdltvl6d2dttqa62uhi%40stwlpdwlftpj

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Use C11 alignas in typedef definitions
- 5c2a8d272b9a 19 (unreleased) landed
Align PGPROC to cache line boundary
- 412f78c66eed 19 (unreleased) landed
Rearrange fields in PGPROC, for clarity
- 2e0853176f8f 19 (unreleased) landed
Split PGPROC 'links' field into two, for clarity
- 36bbcd5be3ff 19 (unreleased) landed
Remove useless store to local variable
- ab32a9e21d37 19 (unreleased) landed
Separate RecoveryConflictReasons from procsignals
- 17f51ea81875 19 (unreleased) cited