Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andreas Karlsson <andreas@proxel.se>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org

Date: 2026-02-13T08:24:30Z

Lists: pgsql-hackers

On Fri, Feb 13, 2026 at 06:46:55AM +0100, Andreas Karlsson wrote:
> Attached a patch which changes that in HEAD and I think for HEAD the best
> solution is the just fix all cases where we use ints like this to actually
> use the enum.

I was expecting something a bit more complicated.  Nice at quick
glance, Andreas.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Reduce presence of syscache.h in src/include/
- e0fa5bd14656 19 (unreleased) landed
Switch SysCacheIdentifier to a typedef enum
- ee642cccc43c 19 (unreleased) landed
Add concept of invalid value to SysCacheIdentifier
- c06b5b99bbb0 19 (unreleased) landed