Re: Some tests for TOAST, STORAGE MAIN/EXTENDED
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-26T00:33:09Z
Lists: pgsql-hackers
On Sun, Jan 25, 2026 at 09:46:51AM +0900, Michael Paquier wrote: > On Fri, Jan 23, 2026 at 12:25:33AM -0800, Nikhil Kumar Veldanda wrote: >> The `SELECT count(*) FROM :reltoastname` assertion is a bit brittle >> for `STORAGE EXTENDED`: depending on the toast compression method / >> effectiveness, the value may end up as >1 chunk, which would flip the >> expected count(*) = 1. Prefer SELECT count(DISTINCT chunk_id) FROM >> :reltoastname (or WHERE chunk_seq = 0) and adjust expected. > > Yeah, this suggestion sounds sensible and that would still notice what > I was able to break. I have settled down to the addition of a qual based on chunk_seq, being consistent with the other test, at the end, then applied the result as 168765e5d42b. Thanks for the suggestions, Nikhil. -- Michael
Commits
-
Add more tests with clause STORAGE on table and TOAST interactions
- 168765e5d42b 19 (unreleased) landed