Horton
Menu

Re: Use correct macro for accessing offset numbers.

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Roman Khapov <rkhapov@yandex-team.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-11T23:23:18Z
Lists: pgsql-hackers 
On Sun, Jan 11, 2026 at 04:58:39PM +0500, Kirill Reshke wrote:
> Maybe, I have stopped some more cases, in v2-0001

Right.  It's true that we could be more consistent for all these based
on their base type, some of them, particularly in the GIN code now,
caring about using the correct macro.  It may be a good occasion to
double-check the whole tree for similar holes based on unsigned types.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust some incorrect *GetDatum() macros

  2. Use more consistent *GetDatum() macros for some unsigned numbers