Horton
Menu

Re: Typos in the code and README

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2026-01-04T23:02:22Z
Lists: pgsql-hackers 
On Thu, Jan 01, 2026 at 10:00:00AM +0200, Alexander Lakhin wrote:
> READ_WRITE_PARSE_PLAN_TREES -> WRITE_READ_PARSE_PLAN_TREES
> DEFAULT_DEBUG_READ_WRITE_PARSE_PLAN_TREES -> DEFAULT_DEBUG_WRITE_READ_PARSE_PLAN_TREES

I thought that this was a bug first, but we also use this name for the
default value.

> replace_s(..., int * adjustment) -> replace_s(..., int * adjptr)

Updating this one contradicts with the upstream sources, see
b464e51ab32f that has done the opposite switch.

> There is also
> extern int        pgwin32_recv(SOCKET s, char *buf, int len, int flags);
> vs
> pgwin32_recv(SOCKET s, char *buf, int len, int f)
> but I've left at as-is; probably the change should be made in the
> implementation...

Using "flags" would be confusing I think as things stand, the code
casts a DWORD with the same name.

> Orphan entities:
> HAVE_ATOMIC_H, HAVE_MBARRIER_H -> remove (per 25f36066d)

Indeed..  It seems slightly cleaner to remove these separately.  Will
do so.

> #ifdef BS_DEBUG in contrib/ltree/ltxtquery_io.c -> remove (introduced with 1dedbf2da)

I am wondering if BS stands for what it means or if it's something
else..
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional