Thread

Re: [PATCH] Fix escaping for '\' and '"' in pageinspect for gist

Michael Paquier <michael@paquier.xyz> — 2025-12-29T23:31:53Z

On Tue, Dec 30, 2025 at 12:29:49AM +0500, Kirill Reshke wrote:
> Yes, split out a function that does quoting after
> OidOutputFunctionCall. that is, this:
> 
> https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/rowtypes.c#L437-L464

FWIW, refactoring that into a single function is something I have
considered while working on e7bff46e50b8, as something that could be
done on HEAD.  At the end, I could not get excited with the result I
got (see the end of the thread) for the amount of lines saved, also
because this impacts a limited area of the code with what seems like a
reduction in readability.
--
Michael